Skip to content

Build skipList before exclude enrichment in apply section#443

Closed
josephwoodward wants to merge 1 commit into
mainfrom
jw/skiplistclaude
Closed

Build skipList before exclude enrichment in apply section#443
josephwoodward wants to merge 1 commit into
mainfrom
jw/skiplistclaude

Conversation

@josephwoodward
Copy link
Copy Markdown
Contributor

No description provided.

@claude
Copy link
Copy Markdown

claude Bot commented Jun 1, 2026

Commits 1. Commit message Build skipList before exclude enrichment in apply section uses sentence-case plain format, but the change is scoped to one system (the workflow processor in internal/impl/pure/). Per repo convention (see prior commit deps: update OTEL package...), scoped changes should use system: message or system(subsystem): message format with a lowercase imperative verb, e.g. processor(workflow): fix skip list ordering when apply and skipped overlap. The wording is also somewhat unclear (exclude enrichment in apply section). Review The fix reorders skipFromMeta so the skipped set is populated before apply is processed, making apply authoritative when both are present (a stage listed in apply now runs even if it also appears in skipped). The behavior when apply is absent is unchanged. The added test case covers the new overlap scenario. LGTM

@claude
Copy link
Copy Markdown

claude Bot commented Jun 1, 2026

Commits

  1. Commit message Build skipList before exclude enrichment in apply section uses sentence-case plain format, but the change is scoped to one system (the workflow processor in internal/impl/pure/). Per repo convention (see prior commit deps: update OTEL package...), scoped changes should use system: message or system(subsystem): message format with a lowercase imperative verb, e.g. processor(workflow): fix skip list ordering when apply and skipped overlap. The wording is also somewhat unclear ("exclude enrichment in apply section").

Review

The fix reorders skipFromMeta so the skipped set is populated before apply is processed, making apply authoritative when both are present (a stage listed in apply now runs even if it also appears in skipped). The behavior when apply is absent is unchanged. The added test case covers the new overlap scenario.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants